Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-edit: 0.3.3 -> 0.4.1 #74981

Merged
merged 1 commit into from Dec 4, 2019
Merged

cargo-edit: 0.3.3 -> 0.4.1 #74981

merged 1 commit into from Dec 4, 2019

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Dec 4, 2019

Motivation for this change

Upgrade and fix broken tests.

Related: #70917
Upstream PR of the patch: killercup/cargo-edit#362

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from Gerschtli and jb55 December 4, 2019 13:09
@Ma27 Ma27 merged commit 034910f into NixOS:master Dec 4, 2019
@sondr3 sondr3 mentioned this pull request Dec 4, 2019
Closed
10 tasks
@killercup
Copy link
Member

Thanks a bunch! I'll make sure to ping you when we release 0.4.2 :)

@killercup killercup mentioned this pull request Dec 4, 2019
Closed
@oxalica oxalica deleted the cargo-edit-upgrade branch August 14, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxalica @killercup @Br1ght0ne @Ma27