gst_all_1.gst-plugins-base: Fix building Wayland support (nullglob fail) #75046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, generic builder sets `nullglob`, disappearing any flags containing square brackets not resolving to file names (e.g. `mesonFlags = [ "-Dgl_winsys=[x11,wayland]" ];`). This caused the `gl_winsys` flag default to `auto` and, since we were missing `wayland-protocols`, Wayland support was not built. Fortunately, Meson also supports simple array notation without square brackets, so we can use that. No need to wait for `_structuredAttrs`. We also no longer set `gl_platform` flag, since passing the default auto value is redundant.
Ma27
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, generic builder sets
nullglob, disappearing any flags containing square brackets not resolving to file names (e.g.mesonFlags = [ "-Dgl_winsys=[x11,wayland]" ];). This caused thegl_winsysflag default toautoand, since we were missingwayland-protocols, Wayland support was not built.Fortunately, Meson also supports simple array notation without square brackets, so we can use that. No need to wait for
_structuredAttrs.We also no longer set
gl_platformflag, since passing the default auto value is redundant.cc @Ma27, @Ericson2314, @globin (d29bcfa#r345472380)