@aanderse Thanks very much for the quick review, I appreciate it :)

For some reason, presumably user error confused, my mobile browser seems to have lost one of the comments I made on this PR. So here we go again... sorry for the noise.

@aanderse for some reason GH has recorded this message as a change request.
Is there anything we need to do there to not have it block the merge?

@aanderse Thanks a lot for this comprehensive and instructive (also: timely ;) ) review !

I tested trilium-desktop and trilium-server. Both worked :)

I used a NixOS container to install trilium-server and then connected from the host:

trilium-container.nix

# Edit this configuration file to define what should be installed on
# your system.  Help is available in the configuration.nix(5) man page
# and in the NixOS manual (accessible by running ‘nixos-help’).

{ config, pkgs, lib, ... }:

{

   services.trilium-server = {
    enable = true;
    nginx = {
      enable = true;
      hostName = "trilium.example.com";
    };
  };

  networking.firewall.enable = false;
}

nixos-container create trilium --config-file trilium-container.nix --host-address 192.168.1.108 --local-address 10.233.0.100

I forgot to mention that trilium-server is not logging to journald. Instead it's logging to a file in dataDir.

I forgot to mention that trilium-server is not logging to journald. Instead it's logging to a file in dataDir.

It is actually doing both, although not quite consistently (https://github.com/zadam/trilium/blob/c4d5060a0b9f2066e661725c6d32ed2f016b8b71/src/services/log.js).
It's also not just the server, the desktop version does this too in ~/.local/share/trilium-data/log.
As there is no way to configure this, I see only the option to patch it on our side.
If anyone thinks it's worth it I'll prepare a patch for review

@emmanuelrosa I've added a patch for the server version that removes the file logger and logs to console only now.
The desktop version is a pre-build electron app, I don't see a good way to patch that without building from source.

@GrahamcOfBorg build trilium-server
@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg test trilium-server

Rebased against master and updated the package version once more.
Anyone willing to push the button? :)

@kampka oops, sorry for the delay. I didn't notice the comments from @emmanuelrosa.

Speaking of which... @emmanuelrosa do you mind hitting the approve button please? I took a very quick look over the package but I would like you as the listed maintainer to give it the official thumbs up.

@kampka can you please address the aarch64 failure?

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@GrahamcOfBorg test trilium-server

@aanderse sorry for the noise, the fact that ofBorg does an "empty" run on unsupported archs threw me of there.
Pinned the executables and tests to x86_64-linux

I don't have an approval button, but nevertheless, I approve :)

Pinned the executables and tests to x86_64-linux

I thought if you marked a package as x86_64-linux tests would only run for that platform. I don't think you need to specifically mention that in the list of tests... but I'm not sure off the top of my head.

I don't have an approval button, but nevertheless, I approve :)

If you review a package you should have the ability to approve, comment, or request changes. Thank you for explicitly stating, though 😄

As an aside... you are marked as a maintainer for this package yet you aren't a member of the NixOS github project 🤔 If this is not by choice we should ping the maintainer of that code because it was my understanding that everyone listed as a maintainer was supposed to be added to the project at one point. Let me know if you want this corrected.

@aanderse, I was involved in developing the original package. I suppose that's why I'm listed as a maintainer. I'd be honored to be a member of the NixOS project.

@aanderse @emmanuelrosa thanks for taking the time to review this guys 👍

@kampka no problem. Thanks for the contribution 🎉
@emmanuelrosa I'm told this should be taken care of at some point today 😄