Don't put the computed value in the title of computed value tests #20606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
requested review from
emilio
and removed request for
frivoal and
gsnedders
emilio
approved these changes
Dec 4, 2019
css/support/computed-testcommon.js
Outdated
| @@ -37,18 +33,13 @@ function test_computed_value(property, specified, computed) { | |||
| assert_equals(getComputedStyle(target)[property], readValue, | |||
| 'computed value should round-trip'); | |||
| } | |||
| }, "Property " + property + " value '" + specified + "' computes to " + | |||
| computedDesc); | |||
| }, "Property " + property + " value '" + specified); | |||
There was a problem hiding this comment.
Close the quote? Or just ${property}: ${value} or such
css/support/computed-testcommon.js
Outdated
| @@ -78,6 +69,5 @@ function test_pseudo_computed_value(pseudo, property, specified, computed) { | |||
| } finally { | |||
| document.documentElement.removeChild(styleElement); | |||
| } | |||
| }, "Property " + property + " value '" + specified + "' computes to " + | |||
| computedDesc + " in " + pseudo); | |||
| }, "Property " + property + " value '" + specified + " in " + pseudo); | |||
There was a problem hiding this comment.
Same, close the single quote that starts with value ' here?
This can vary so doesn't make a unique test title.
jgraham
force-pushed
the
no_expected_in_test_name
branch
from
a12a706
to
a517cae
Compare
wpt-pr-bot
requested review from
dbaron,
fantasai,
FremyCompany,
plinss and
tabatkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can vary so doesn't make a unique test title.