Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heimer: init at 1.12.0 #75029

Merged
merged 4 commits into from Jan 1, 2020
Merged

heimer: init at 1.12.0 #75029

merged 4 commits into from Jan 1, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 5, 2019

Motivation for this change

"Simple cross-platform mind map and note-taking tool written in Qt"

馃槆 meant to submit this earlier, but better later than never!
Enjoy!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented.

pkgs/applications/misc/heimer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/heimer/default.nix Show resolved Hide resolved
pkgs/applications/misc/heimer/default.nix Show resolved Hide resolved
@dtzWill
Copy link
Member Author

dtzWill commented Jan 1, 2020

The use of mkDerivation is so that wrapping is done correctly since this is a qt app.

I'll simplify rev to what you suggest as it's cleaner and probably better supported -- the refs/tags/ bit is to ensure the tag is used not a branch that may have that name (habit picked up after seeing this happen a time or three :)).

It doesn't seem to generally be a problem, I should probably start doing it that way by default O:).

@dtzWill
Copy link
Member Author

dtzWill commented Jan 1, 2020

Thanks! <3

@dtzWill dtzWill merged commit 7e5334d into NixOS:master Jan 1, 2020
@dtzWill dtzWill deleted the feature/heimer branch January 1, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @doronbehar