Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fractal: 4.2.0 -> 4.2.2 #75030

Merged
merged 1 commit into from Dec 5, 2019
Merged

fractal: 4.2.0 -> 4.2.2 #75030

merged 1 commit into from Dec 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 5, 2019

gtksourceview4, patch's MR accepted \o/, add gst-validate dep

Things done

(still building on Nixpkgs master, but don't expect any problems....)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill @worldofpeace

@dtzWill
fractal: 4.2.0 -> 4.2.2
d1435b4 
gtksourceview4, patch's MR accepted \o/, add gst-validate dep
@worldofpeace
Copy link
Contributor

Thanks @dtzWill, was purposely waiting for this release because the prior had issues.

@ofborg ofborg bot requested a review from worldofpeace December 5, 2019 05:08
@worldofpeace
Copy link
Contributor

Release Notes: https://gitlab.gnome.org/GNOME/fractal/blob/master/fractal-gtk/res/org.gnome.Fractal.appdata.xml.in.in

@worldofpeace worldofpeace merged commit d49dba4 into NixOS:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @worldofpeace