Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nixpkgs-pytools: 1.0.1 -> 1.3.0 #70661

Merged
merged 1 commit into from Oct 8, 2019
Merged

pythonPackages.nixpkgs-pytools: 1.0.1 -> 1.3.0 #70661

merged 1 commit into from Oct 8, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 7, 2019

Motivation for this change

Update to latest nixpkgs-pytools. Requires new dependency rope, that is why it probably was not caught by @r-ryantm :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @costrouc

@makefu makefu requested a review from FRidh as a code owner October 7, 2019 18:37
@ofborg ofborg bot requested a review from costrouc October 7, 2019 18:56
@makefu makefu force-pushed the pkgs/nixpkgs-pytools/update branch 2 times, most recently from 36b8faa to 681e63a Compare October 7, 2019 19:27
@ofborg ofborg bot requested a review from nlewo October 7, 2019 19:36
@nlewo
Copy link
Member

nlewo commented Oct 8, 2019

@GrahamcOfBorg build python3Packages.nixpkgs-pytools

@nlewo nlewo merged commit f6b8aed into NixOS:master Oct 8, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 23, 2019
@nlewo @dtzWill
Merge pull request NixOS#70661 from makefu/pkgs/nixpkgs-pytools/update
195ff88 
pythonPackages.nixpkgs-pytools: 1.0.1 -> 1.3.0

(cherry picked from commit f6b8aed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makefu @nlewo