Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oil: enable readline #70531

Merged
merged 2 commits into from Oct 7, 2019
Merged

oil: enable readline #70531

merged 2 commits into from Oct 7, 2019

Conversation

illfygli
Copy link
Contributor

@illfygli illfygli commented Oct 6, 2019

Motivation for this change

The current package does not include readline, which results in a shell that lacks interactive features.
Also added passthrough.shellPath so that it can be used as a shell package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann

@dywedir
Copy link
Member

dywedir commented Oct 6, 2019

@GrahamcOfBorg build oil

@lheckemann
Copy link
Member

@GrahamcOfBorg build oil

@lheckemann lheckemann merged commit e831ebc into NixOS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants