Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zathura 0.4.3 > 0.4.4 (and girara 0.3.2 -> 0.3.3) #70530

Merged
merged 2 commits into from Oct 7, 2019
Merged

zathura 0.4.3 > 0.4.4 (and girara 0.3.2 -> 0.3.3) #70530

merged 2 commits into from Oct 7, 2019

Conversation

samdoshi
Copy link
Contributor

@samdoshi samdoshi commented Oct 6, 2019

Motivation for this change

Update zathura to 0.4.4 as well girara to 0.3.3 (it's a required update for zathura).

Updated the source URLs and homepages to use https://git.pwmt.org/pwmt as https://pwmt.org is down (and AFAIK has been for a while).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin

@samdoshi
girara: 0.3.2 -> 0.3.3
1aa3e67 
Source URL and homepage also updated.
@samdoshi
zathura: 0.4.3 -> 0.4.4
2678b8e 
Source URL and homepage also updated.
ck3d
ck3d approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could successfully view a pdf file. Tested with nix-review.

@globin globin merged commit 7c3e8cd into NixOS:master Oct 7, 2019
@samdoshi samdoshi deleted the zathura branch April 9, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdoshi @ck3d @globin