Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.20.1 -> 0.20.2 #70456

Merged
merged 2 commits into from Oct 5, 2019
Merged

starship: 0.20.1 -> 0.20.2 #70456

merged 2 commits into from Oct 5, 2019

Conversation

davidtwco
Copy link
Member

Motivation for this change

v0.20.2 of Starship was released.

I've also included a commit which adds myself to the maintainers of this package - I've now submitted a handful of PRs to update it (#70385, #69501 and #68922) and I'm happy to help with the continued maintenance of this package. @bbigras are you OK with this?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bbigras

@teto
Copy link
Member

teto commented Oct 5, 2019

@GrahamcOfBorg build starship

@ofborg ofborg bot requested a review from bbigras October 5, 2019 12:23
@teto teto merged commit 299ecd4 into NixOS:master Oct 5, 2019
@davidtwco davidtwco deleted the starship-0.20.2 branch October 5, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras Awaiting requested review from bbigras

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @teto