Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mpld3: init at 0.3 #70457

Closed
wants to merge 1 commit into from
Closed

pythonPackages.mpld3: init at 0.3 #70457

wants to merge 1 commit into from

Conversation

unode
Copy link
Member

@unode unode commented Oct 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tests are currently disabled as they require access to an X display.

@unode unode requested a review from FRidh as a code owner October 5, 2019 12:31
@unode unode mentioned this pull request Oct 5, 2019
Closed
10 tasks
worldofpeace
worldofpeace suggested changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit message for a python package is mixed up here.

It should be

package_attribute: init at version

so this would be

pythonPackages.mpld3: init at 0.3

@unode
Copy link
Member Author

unode commented Oct 5, 2019

@worldofpeace my bad. Fixed now.

@unode unode changed the title init: mpld3 at 0.3 pythonPackages.mpld3: init at 0.3 Oct 6, 2019
@risicle
Copy link
Contributor

risicle commented Oct 6, 2019

It's actually possible to get the tests running by encouraging matplotlib to use e.g. the ps backend something like:

  checkInputs = [ nose ];
  checkPhase = ''
    export HOME=$TMPDIR
    mkdir -p $HOME/.config/matplotlib
    echo "backend: ps" > $HOME/.config/matplotlib/matplotlibrc
    ln -s $HOME/.config/matplotlib $HOME/.matplotlib

    nosetests mpld3
  '';

However a number of these tests genuinely fail and I'm not totally sure about the compatibility of this release with our current matplotlib and numpy. Do you find this package works well enough for you?

@unode
Copy link
Member Author

unode commented Oct 7, 2019

I mostly got to this package as a dependency of #70458 .

On my system the package works but is quirky. Hard to say if due to NixOS or the package itself as there are several open issues on the official issue tracker. Version 0.3 was released in 2016 so, a bit old. The repository is still being somewhat maintained so hopefully a new release will happen at some point in the near future.

Tests are also failing in the official repository so these might be upstream issues.

@risicle
Copy link
Contributor

risicle commented Oct 7, 2019

If we're referring to the same thing, the "tests failing in the main repository" look like they just haven't set up travis properly. But yeah, it seems they haven't really kept up with dependencies and with nixpkgs insistence on "one version of everything" and very recent versions, this causes trouble. If you're a competent python programmer, you can always fork the project & fix it of course...

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pytest-bdd-on-shell-nix/4616/4

vyp
vyp suggested changes Nov 2, 2019
View reviewed changes
pkgs/development/python-modules/mpld3/default.nix Outdated

meta = with stdenv.lib; {
description = "D3 Viewer for Matplotlib";
homepage = "http://mpld3.github.io";
Copy link
Member

@vyp vyp Nov 2, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "http://mpld3.github.io";
homepage = "http://mpld3.github.io";
license = licenses.bsd3;

@unode unode requested a review from jonringer as a code owner November 3, 2019 17:26
worldofpeace
worldofpeace reviewed Nov 3, 2019
View reviewed changes
pkgs/development/python-modules/mpld3/default.nix
doCheck = false;

meta = with stdenv.lib; {
description = "D3 Viewer for Matplotlib";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't align these vertically, it's not a part of the nix style in the nixpkgs manual nor is it maintained.
Prospective formatters are being created without this as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a reference from some other location. Now fixed to not be vertically aligned.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build pythonPackages.mpld3

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

@unode unode deleted the mpld3 branch November 8, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@vyp vyp vyp requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@unode @risicle @nixos-discourse @matthewbauer @SuperSandro2000 @vyp @worldofpeace @ryantm