Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-cpp: 0.11.0 -> 0.14.0 #70485

Merged
merged 1 commit into from Oct 15, 2019
Merged

google-cloud-cpp: 0.11.0 -> 0.14.0 #70485

merged 1 commit into from Oct 15, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 5, 2019

This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig
for more of the dependencies. On top of that, the installation looks
much better (we don't need to fixup library paths and move files around)

On top of that, upstream introduced another intermediate dependency
(googleapis-cpp-cmakefiles).

Obsoletes #67769.

Motivation for this change

Debugging recent google-cloud-cpp bindings improvements which might fix googleapis/google-cloud-cpp#3029, and enable NixOS/nix#3021.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir @tazjin

@flokli
google-cloud-cpp: 0.11.0 -> 0.14.0
5e225b7 
This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig
for more of the dependencies. On top of that, the installation looks
much better (we don't need to fixup library paths and move files around)

On top of that, upstream introduced another intermediate dependency
(googleapis-cpp-cmakefiles).

Obsoletes NixOS#67769.
@flokli flokli requested a review from andir October 5, 2019 18:43
@flokli
Copy link
Contributor Author

flokli commented Oct 5, 2019

The fix to be able to build (pkgs.enableDebugging pkgs.google-cloud-cpp) from 9576c84 isn't necessary anymore.

@flokli flokli mentioned this pull request Oct 5, 2019
Closed
10 tasks
flokli
flokli commented Oct 5, 2019
View reviewed changes
pkgs/development/libraries/google-cloud-cpp/default.nix
buildInputs = [ c-ares c-ares.cmake-config grpc openssl protobuf zlib ];

postPatch = ''
sed -e 's,https://github.com/googleapis/googleapis/archive/9c9f778aedde02f9826d2ae5d0f9c96409ba0f25.tar.gz,file://${googleapis},' \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand why setting -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_URL in cmakeFlags doesn't work :-/

@flokli flokli mentioned this pull request Oct 5, 2019
Closed
@flokli
Copy link
Contributor Author

flokli commented Oct 6, 2019

I was able to upload to GCS via NixOS/nix#3021, so am tempted to merge into master and 19.09. @andir, any opinions?

@globin globin merged commit c4f5657 into NixOS:master Oct 15, 2019
@flokli flokli deleted the google-cloud-cpp-0.14.0 branch October 16, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCS upload timeout / spinning in poll
2 participants
@flokli @globin