google-cloud-cpp: 0.11.0 -> 0.14.0 #70485
Merged
+35
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig for more of the dependencies. On top of that, the installation looks much better (we don't need to fixup library paths and move files around) On top of that, upstream introduced another intermediate dependency (googleapis-cpp-cmakefiles). Obsoletes NixOS#67769.
|
The fix to be able to build |
10 tasks
flokli
commented
Oct 5, 2019
| buildInputs = [ c-ares c-ares.cmake-config grpc openssl protobuf zlib ]; | ||
|
|
||
| postPatch = '' | ||
| sed -e 's,https://github.com/googleapis/googleapis/archive/9c9f778aedde02f9826d2ae5d0f9c96409ba0f25.tar.gz,file://${googleapis},' \ |
There was a problem hiding this comment.
I don't really understand why setting -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_URL in cmakeFlags doesn't work :-/
flokli
commented
Oct 5, 2019
ofborg
bot
added
11.by: package-maintainer
|
I was able to upload to GCS via NixOS/nix#3021, so am tempted to merge into master and 19.09. @andir, any opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig
for more of the dependencies. On top of that, the installation looks
much better (we don't need to fixup library paths and move files around)
On top of that, upstream introduced another intermediate dependency
(googleapis-cpp-cmakefiles).
Obsoletes #67769.
Motivation for this change
Debugging recent google-cloud-cpp bindings improvements which might fix googleapis/google-cloud-cpp#3029, and enable NixOS/nix#3021.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @andir @tazjin