vscode: Make it so that it places the .app in $out/Applications on macOS #70486
Conversation
|
Worth noting, this will fix #47553 in theory. |
| ln -s $out/lib/vscode/Contents/Resources/app/bin/${executableName} $out/bin | ||
| mkdir -p "$out/Applications/${longName}.app" $out/bin | ||
| cp -r ./* "$out/Applications/${longName}.app" | ||
| ln -s "$out/Applications/${longName}.app/Contents/Resources/app/bin/code" $out/bin/${executableName} |
There was a problem hiding this comment.
| ln -s "$out/Applications/${longName}.app/Contents/Resources/app/bin/code" $out/bin/${executableName} | |
| ln -s "$out/Applications/${longName}.app/Contents/Resources/app/bin/${executableName}" $out/bin/${executableName} |
Why was that ^ changed? Is that not important for the macos build artifact?
There was a problem hiding this comment.
This was done because for whatever reason the vscodium macOS release .zip doesn't have the code utility renamed to codium
There was a problem hiding this comment.
I see, can you add a comment? This installPhase is already completely uncommented, and if I were to notice this not using executableName I would for sure change that and break things.
There was a problem hiding this comment.
I would be surprised to see a PR that changes working code from a static path reference to using a variable. I agree that a comment is probably a good idea, but my first impression upon reading this code is simply that the app includes a binary named app/bin/code, and I wouldn't question that.
|
Just requesting review of people I'm aware of that use darwin for testing. |
Motivation for this change
vscode and vscodium when installed under nix-darwin don't appear in the
~/Applications/Nix Appsfolder, due to how the $out is placed.Things done
Make it so that on macOS instead of extracting the contents of the app into
$out/lib/vscodeit goes into$out/Applications/${longName}.appwhich will then be linked to the correct place by nix-darwinsandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @eadwu @Synthetica