Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc: v1.0.0-rc8 -> v1.0.0-rc9 #70464

Merged
merged 1 commit into from Oct 12, 2019
Merged

runc: v1.0.0-rc8 -> v1.0.0-rc9 #70464

merged 1 commit into from Oct 12, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 5, 2019 •
edited

Motivation for this change

Updating runc to the latest version to fix CVE-2019-16884

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@saschagrunert
runc: v1.0.0-rc8 -> v1.0.0-rc9
ed633cb 
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@saschagrunert
Copy link
Member Author

cc @offline

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build runc

@c0bw3b c0bw3b added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 6, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2019

@GrahamcOfBorg test docker-tools

vdemeester
vdemeester approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70464: runc: v1.0.0-rc8 -> v1.0.0-rc9 (security)
0fa45b8
@vcunat vcunat merged commit ed633cb into NixOS:master Oct 12, 2019
vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70464: runc: v1.0.0-rc8 -> v1.0.0-rc9 (security)
92ab741 
(cherry picked from commit 0fa45b8)
CVE-2019-16884
@saschagrunert
Copy link
Member Author

@c0bw3b do I have to take care of the port to stable manually? Is it just a cherry pick to the stable branch? :)

@saschagrunert saschagrunert deleted the runc branch October 12, 2019 08:19
@vcunat
Copy link
Member

vcunat commented Oct 12, 2019

I'm taking care of that already ;-)

vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70464: runc: v1.0.0-rc8 -> v1.0.0-rc9 (security)
aff4d64 
(cherry picked from commit 0fa45b8)
CVE-2019-16884
@saschagrunert
Copy link
Member Author

Thanks!

@vcunat vcunat added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 12, 2019
@d-goldin d-goldin mentioned this pull request Oct 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@vcunat vcunat vcunat approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @c0bw3b @vcunat @vdemeester