Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: Update CRAN and bioconductor packages #70460

Closed
wants to merge 1 commit into from
Closed

R: Update CRAN and bioconductor packages #70460

wants to merge 1 commit into from

Conversation

jabranham
Copy link
Contributor

Motivation for this change

Update R package set

Things done

Ran nix-build test-evaluation.nix --dry-run

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@jabranham jabranham requested a review from peti as a code owner October 5, 2019 12:46
@peti
Copy link
Member

peti commented Oct 6, 2019

Test builds of 064aebf2bb5c2dace7128e528e6f8a2211f6a146 are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates.

@peti
Copy link
Member

peti commented Oct 6, 2019

There are 2000+ newly broken packages after this update. :-(

I added aedf9aa6ccbdc0ef8efc11c8e1468f36820f4526 to the r-updates branch. That should fix some of them. But it's probably a good idea to fix some more pivotal packages before we merge.

@peti
Copy link
Member

peti commented Oct 6, 2019

0537d3cdbe96524d53de856d5933bac99a07fd8f should improve matters some more ...

@jabranham
Copy link
Contributor Author

Thanks. Looks like between those two commits we're back up to about the same numbers as before.

@peti
Copy link
Member

peti commented Oct 6, 2019

Merged to master.

@peti peti closed this Oct 6, 2019
@jabranham jabranham deleted the r-packages branch October 6, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jabranham @peti