Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkd: 3.8.5 -> 3.9.0 #70662

Merged
merged 2 commits into from Oct 12, 2019
Merged

gtkd: 3.8.5 -> 3.9.0 #70662

merged 2 commits into from Oct 12, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #65087.
The issue there with tilix not building was because of the .pc's not being installed.
And that's been fixed in gtkd-developers/GtkD@a9db091.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

midchildan
midchildan approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@midchildan midchildan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it works on my laptop. LGTM.

@worldofpeace worldofpeace merged commit d4f0850 into NixOS:master Oct 12, 2019
@worldofpeace worldofpeace deleted the gtkd-update branch October 12, 2019 18:35
@worldofpeace
Copy link
Contributor Author

Thanks @midchildan ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan midchildan approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @midchildan