[Native File System] getFile() returns a File sized correctly #19553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845998
branch
from
fe7a8bf
to
bcf0f24
Compare
The getFile() method on NativeFileSystemFileHandleImpl returned a File that wasn't sized correctly. This caused issues when trying to use methods on the File object that would use the bounds to do operations. BUG=1011179 Change-Id: If900ac39be6b7bfc9d693680aa5d20b6b9c926d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845998 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#703764}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845998
branch
from
bcf0f24
to
fbed778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getFile() method on NativeFileSystemFileHandleImpl returned a File
that wasn't sized correctly. This caused issues when trying to use
methods on the File object that would use the bounds to do operations.
BUG=1011179
Change-Id: If900ac39be6b7bfc9d693680aa5d20b6b9c926d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845998
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703764}