Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 56e1ea32f4d0
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f760f0ef4868
Choose a head ref
  • 1 commit
  • 7 files changed
  • 1 contributor

Commits on Oct 7, 2019

  1. Revert "Merge #67232: machinectl compliant NixOS installation"

    This reverts commit 66967ec, reversing
    changes made to fb6595e.
    Fixes #70442; discussion: #70027
    vcunat committed Oct 7, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    vcunat Vladimír Čunát
    Copy the full SHA
    f760f0e View commit details
37 changes: 0 additions & 37 deletions nixos/doc/manual/installation/installing-nspawn-container.xml

This file was deleted.

3 changes: 0 additions & 3 deletions nixos/doc/manual/installation/installing.xml
Original file line number Diff line number Diff line change
@@ -563,8 +563,5 @@ Retype new UNIX password: ***</screen>
<xi:include href="installing-from-other-distro.xml" />

<xi:include href="installing-behind-a-proxy.xml" />

<xi:include href="installing-nspawn-container.xml" />

</section>
</chapter>
3 changes: 1 addition & 2 deletions nixos/modules/installer/tools/nixos-install.sh
Original file line number Diff line number Diff line change
@@ -132,9 +132,8 @@ if [[ -z $noBootLoader ]]; then
echo "installing the boot loader..."
# Grub needs an mtab.
ln -sfn /proc/mounts $mountPoint/etc/mtab
export NIXOS_INSTALL_BOOTLOADER=1
NIXOS_INSTALL_BOOTLOADER=1 nixos-enter --root "$mountPoint" -- /run/current-system/bin/switch-to-configuration boot
fi
nixos-enter --root "$mountPoint" -- /run/current-system/bin/switch-to-configuration boot

# Ask the user to set a root password, but only if the passwd command
# exists (i.e. when mutable user accounts are enabled).
7 changes: 0 additions & 7 deletions nixos/modules/system/activation/activation-script.nix
Original file line number Diff line number Diff line change
@@ -184,14 +184,7 @@ in
find /var/empty -mindepth 1 -delete
chmod 0555 /var/empty
chown root:root /var/empty
${ # reasons for not setting immutable flag:
# 1. flag is not changeable inside a container
# 2. systemd-nspawn can not perform chown in case of --private-users-chown
# then the owner is nobody and ssh will not start
optionalString (!config.boot.isContainer) ''
${pkgs.e2fsprogs}/bin/chattr -f +i /var/empty || true
''}
'';

system.activationScripts.usrbinenv = if config.environment.usrbinenv != null
2 changes: 1 addition & 1 deletion nixos/modules/virtualisation/container-config.nix
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ with lib;
services.udisks2.enable = mkDefault false;
powerManagement.enable = mkDefault false;

networking.useHostResolvConf = mkDefault (!config.services.resolved.enable);
networking.useHostResolvConf = mkDefault true;

# Containers should be light-weight, so start sshd on demand.
services.openssh.startWhenNeeded = mkDefault true;
1 change: 0 additions & 1 deletion nixos/tests/all-tests.nix
Original file line number Diff line number Diff line change
@@ -262,7 +262,6 @@ in
syncthing-relay = handleTest ./syncthing-relay.nix {};
systemd = handleTest ./systemd.nix {};
systemd-confinement = handleTest ./systemd-confinement.nix {};
systemd-machinectl = handleTest ./systemd-machinectl.nix {};
systemd-timesyncd = handleTest ./systemd-timesyncd.nix {};
systemd-networkd-wireguard = handleTest ./systemd-networkd-wireguard.nix {};
pdns-recursor = handleTest ./pdns-recursor.nix {};
52 changes: 0 additions & 52 deletions nixos/tests/systemd-machinectl.nix

This file was deleted.