Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: add a themePackages module option so themes are not installed globally #70494

Closed
wants to merge 1 commit into from
Closed

sddm: add a themePackages module option so themes are not installed globally #70494

wants to merge 1 commit into from
+18 −2

Conversation

illegalprime
Copy link
Member

Motivation for this change

This allows users to keep SDDM theme packages separated from the system environment by adding a NixOS module option to store all the theme packages in. The user is still required to select the theme to use with the theme option, but they now don't need to put it in environment.systemPackages.

This is an implementation of what's discussed in #59016 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 5, 2019
@illegalprime illegalprime mentioned this pull request Oct 5, 2019
Closed
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 5, 2019
@eadwu
Copy link
Member

eadwu commented Oct 6, 2019

This doesn't seem to address the propagation of the qt dependencies for non KDE systems.

@matthewbauer
Copy link
Member

matthewbauer commented Oct 6, 2019 •
edited
Loading

I don't like this change. It restricts sddm theming without any obvious purpose. It's useful to have environment.systemPackages apply in many different places. That way a package can provide for instance fonts, icons, plasma5 themes, and sddm themes all in one place.

In addition, I think this is a breaking change? Users need to move all of their sddm themes from environment.systemPackages to sddm.themePackages.

@illegalprime
Copy link
Member Author

Yeah I agree with @matthewbauer , didn't see that, closing.

@jdnixx jdnixx mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illegalprime @eadwu @matthewbauer @michaelpj