Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molly-guard: 0.6.3 -> 0.7.2 #70498

Merged
merged 1 commit into from Oct 10, 2019
Merged

molly-guard: 0.6.3 -> 0.7.2 #70498

merged 1 commit into from Oct 10, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Oct 5, 2019 •
edited

Motivation for this change

Notable changes:

  • Pass through "halt -w" and "halt -f" commands
  • Pass through "reboot -f" command
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from DerTim1 October 5, 2019 22:28
@nlewo nlewo merged commit 6cee5a9 into NixOS:master Oct 10, 2019
@nyanloutre nyanloutre deleted the molly_guard_0_7_2 branch October 10, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerTim1 DerTim1 DerTim1 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @DerTim1 @nlewo