Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-chili: init at 0.5.5 #70495

Closed
wants to merge 1 commit into from
Closed

plasma-chili: init at 0.5.5 #70495

wants to merge 1 commit into from

Conversation

illegalprime
Copy link
Member

@illegalprime illegalprime commented Oct 5, 2019 •
edited

Motivation for this change

Add an SDDM theme similar to the one in #59016 but this one is specifically made to work with a plasma desktop (according to the maintainer). That along with the other few SDDM PRs (#70492 #70494) makes SDDM configuration much clearer (IMO). Here's a picture of a VirtualBox instance with everything working:

Screenshot_20191005_173609

{
  services.xserver.displayManager.sddm.themePackages = with pkgs; [
    (callPackage ./sddm-theme-plasma-chili.nix {})
  ];
  services.xserver.displayManager.sddm.theme = "plasma-chili";

  services.xserver.displayManager.sddm.faces.michael = "${./face.icon}";
}

One question I have is with naming, the package is called plasma-chili-theme, but where should l document that a user should set sddm.theme to "plasma-chili" if they want to correctly use the theme?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@michaelpj
Copy link
Contributor

I was just looking at packaging some sddm themes and wondering about that. Perhaps it would be appropriate to put the theme name in passthru?

eadwu
eadwu reviewed Oct 6, 2019
View reviewed changes
pkgs/data/themes/chili/plasma-chili.nix
rev = "${version}";
sha256 = "17pkxpk4lfgm14yfwg6rw6zrkdpxilzv90s48s2hsicgl3vmyr3x";
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing qt dependencies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs any? They're not used directly by the theme, they need to be available wherever the theme is available (which I think is in SDDM). Or maybe they are already in environment.systemPackages from some leak somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I see what you're saying, I should test this with a system that has no other Qt desktop managers / libraries?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah like using SDDM without the KDE desktop environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you maybe need to do something like in https://github.com/NixOS/nixpkgs/pull/59016/files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have success with the propagatedBuildInputs since there seemed to be changes to the build process for qt. Settled for propagatedUserEnvPkgs on a local derivation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should it be using qt.mkDerivation? As is apparently now the way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly from my efforts in the past, that doesn't make a difference, since the theme has no executables and the buildInputs no longer propagate, there is nothing to be wrapped so the theme won't be able to find the libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eadwu Can we merge without this being fixed?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@rodrigondec
Copy link
Contributor

still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 16, 2020
ryantm
ryantm requested changes Sep 24, 2020
View reviewed changes
pkgs/data/themes/chili/plasma-chili.nix
meta = with stdenv.lib; {
license = licenses.gpl3;
maintainers = with maintainers; [ illegalprime ];
homepage = https://github.com/MarianArlt/sddm-chili;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please quote per RFC 45 NixOS/rfcs#45

pkgs/data/themes/chili/plasma-chili.nix
'';

meta = with stdenv.lib; {
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = licenses.gpl3;
license = licenses.gpl3Plus;

The source files mention that later versions are okay.

@SuperSandro2000
Copy link
Member

@illegalprime ping

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

@sents sents mentioned this pull request Apr 2, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@eadwu eadwu eadwu left review comments

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@illegalprime @michaelpj @rodrigondec @SuperSandro2000 @ryantm @eadwu