Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groff: 1.22.3 -> 1.22.4 #70500

Merged
merged 1 commit into from Oct 22, 2019
Merged

groff: 1.22.3 -> 1.22.4 #70500

merged 1 commit into from Oct 22, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Oct 6, 2019 •
edited

Motivation for this change

Despite being only a patch version bump, this represents 4 years of changes.

1.22.4 respects SOURCE_DATE_EPOCH which eliminates some reproducibility problems. I expect this to remove man-db and 3 automake entries from @grahamc s https://r13y.com list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bgamari @pSub

@ofborg ofborg bot requested a review from pSub October 6, 2019 05:25
@tilpner
Copy link
Member Author

tilpner commented Oct 6, 2019 •
edited

Note that texinfo' and bison' or `byacc' are required only for
building from repository sources (either a checked out working copy,
or a commit snapshot). They are not required for building from a
stable release tarball
-- README

We could probably get away without the texinfo input, if that's preferred.
Just removing it from the inputs errors about a missing makeinfo though, about which build-aux/missing has the following to say:

  echo "You should only need it if you modified a '.texi' file, or"
  echo "any other file indirectly affecting the aspect of the manual."
  echo "You might want to install the Texinfo package:"
  echo "<$gnu_software_URL/texinfo/>"
  echo "The spurious makeinfo call might also be the consequence of"
  echo "using a buggy 'make' (AIX, DU, IRIX), in which case you might"
  echo "want to install GNU make:"
  echo "<$gnu_software_URL/make/>"

I don't see why a .texi file would have been modified. Considering the fairly small build closure size addition (6.6MB), I will keep texinfo for now.

@grahamc
Copy link
Member

grahamc commented Oct 18, 2019

I don't feel qualified to approve this ,but it should be pointed at the staging branch :)

@tilpner tilpner changed the base branch from master to staging October 18, 2019 19:17
@FRidh FRidh merged commit d0c1ee5 into NixOS:staging Oct 22, 2019
@raboof raboof mentioned this pull request Oct 29, 2019
Closed
samueldr added a commit to samueldr/nixpkgs that referenced this pull request Nov 9, 2019
@samueldr
groff: Fix cross-compilation
313cef8 
Fixup the patch from 4f3c817 so it
applies to the current groff.

The patch was removed, but cross-compilation not validated, in NixOS#70500.
@samueldr samueldr mentioned this pull request Nov 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tilpner @grahamc @FRidh