gnome3.gnome-session: always run /etc/set-environment on startup #70501
Conversation
ofborg
bot
added
the
6.topic: GNOME
ofborg
bot
added
11.by: package-maintainer
gnomes-session sources its environment from a login shell. But if the systemd user environment already contains `__NIXOS_SET_ENVIRONMENT_DONE` the environment setup won't happen correctly. Simply unset this variable to ensure a fresh environment. This was previously handled by a GDM patch, but it no longer works reliably with gnome-sessions systemd session. We still need the GDM patch to handle running other sessions (eg. plasma). See NixOS#48255 for more info on the underlying issue.
hedning
force-pushed
the
fix-gnome-session-env-setup
branch
from
c53c5ca to
a436602
Compare
|
It seems there's a patch upstream where they copy the same spawn_session code in GDM to gnome-session |
Yeah, I tried to patch it like gdm without success (tried with I mean we want gnome-session to always source the environment on startup, so unsetting |
|
@hedning I agree. It's very simple 👍 Are there patches we could consolidate in gdm that PAM env makes unneeded? |
|
So this didn't work completely. While crashing my session a bunch of times testing So I'd say we should work towards getting the pam environment to work correctly and rely on that. Getting the environment sourced correctly from the shell just doesn't work it seems :/ |
|
Yeah, the failure I saw was with a436602, but without #70430. I'm fairly certain that the wrapperDir fix actually resolves the issue, just strange that a436602 doesn't work by itself. Perhaps the pam environment somehow takes precedent (though that wouldn't explain why eg. the first login works) 😕 I guess with a436602 we can at least be more confident that users will get stuff they've set using |
Motivation for this change
gnomes-session sources its environment from a login shell. But if the systemd
user environment already contains
__NIXOS_SET_ENVIRONMENT_DONEthe environmentsetup won't happen correctly. Simply unset this variable to ensure a fresh
environment.
This was previously handled by a GDM patch, but it no longer works reliably with
gnome-sessions systemd session.
This means we can drop the not so reliable patch in gdm.We still need the patch to handle plasma et. al.See #48255 for more info on the
underlying issue.
With the newly added pam environment (and #70430) this shouldn't be strictly necessary, but it does clean up a now broken fix. No idea why I didn't just fix it like this in the first place 😆 (did it in GDM to handle other sessions obviously).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @