Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.devpi-common: 3.3.2 -> 3.4.0 #70667

Merged
merged 1 commit into from Oct 7, 2019
Merged

pythonPackages.devpi-common: 3.3.2 -> 3.4.0 #70667

merged 1 commit into from Oct 7, 2019

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 7, 2019

Motivation for this change

In preparation for bumping devpi-client to 5.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [N/A] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@makefu makefu requested a review from FRidh as a code owner October 7, 2019 19:38
@ofborg ofborg bot requested a review from nlewo October 7, 2019 19:53
jonringer
jonringer approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[5 built, 49 copied (58.2 MiB), 10.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70667
1 package are marked as broken and were skipped:
devpi-client

3 package were build:
devpi-server python27Packages.devpi-common python37Packages.devpi-common

@jonringer
Copy link
Contributor

@GrahamcOfBorg build devpi-server python27Packages.devpi-common python37Packages.devpi-common

@jonringer jonringer merged commit b81de29 into NixOS:master Oct 7, 2019
@makefu
Copy link
Contributor Author

makefu commented Oct 8, 2019

thanks! I've opened PR #70721 for devpi-client

@makefu makefu deleted the pkgs/devpi-common/update branch October 8, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makefu @jonringer