Change key from "Ctrl" to "Shift" in actionsWithKeyPressed.html #19555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845994
branch
from
42e4fd2
to
eac2457
Compare
In this test, we want to test that testdriver Action API supports key and mouse action interactions. Clicking with "Ctrl" key pressed on Mac causes a context menu open, which fails itself and prevents a subsequent test from running. We can use other keys such as "Shift" or "Alt", which do not open any context menu. Change-Id: Id9b48440306eeddbd97114bc1ac0f4c9c3c012fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845994 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703792}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1845994
branch
from
eac2457
to
f731d30
Compare
foolip
pushed a commit
that referenced
this pull request
Oct 9, 2019
The offending test has been fixed in #19555.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 24, 2019
…=testonly Automatic update from web-platform-tests Unskip testdriver Actions infra tests (#19497) The offending test has been fixed in web-platform-tests/wpt#19555. -- wpt-commits: 8f21bdd2710f97b928cbe909f20adcfbc072b13c wpt-pr: 19497
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Oct 24, 2019
…=testonly Automatic update from web-platform-tests Unskip testdriver Actions infra tests (#19497) The offending test has been fixed in web-platform-tests/wpt#19555. -- wpt-commits: 8f21bdd2710f97b928cbe909f20adcfbc072b13c wpt-pr: 19497
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 27, 2019
…=testonly Automatic update from web-platform-tests Unskip testdriver Actions infra tests (#19497) The offending test has been fixed in web-platform-tests/wpt#19555. -- wpt-commits: 8f21bdd2710f97b928cbe909f20adcfbc072b13c wpt-pr: 19497 UltraBlame original commit: ee0d6472726c4cb731da9dc0710c63cfb88765d9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 27, 2019
…=testonly Automatic update from web-platform-tests Unskip testdriver Actions infra tests (#19497) The offending test has been fixed in web-platform-tests/wpt#19555. -- wpt-commits: 8f21bdd2710f97b928cbe909f20adcfbc072b13c wpt-pr: 19497 UltraBlame original commit: ee0d6472726c4cb731da9dc0710c63cfb88765d9
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 27, 2019
…=testonly Automatic update from web-platform-tests Unskip testdriver Actions infra tests (#19497) The offending test has been fixed in web-platform-tests/wpt#19555. -- wpt-commits: 8f21bdd2710f97b928cbe909f20adcfbc072b13c wpt-pr: 19497 UltraBlame original commit: ee0d6472726c4cb731da9dc0710c63cfb88765d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this test, we want to test that testdriver Action API supports key
and mouse action interactions. Clicking with "Ctrl" key pressed on Mac
causes a context menu open, which fails itself and prevents a
subsequent test from running. We can use other keys such as "Shift"
or "Alt", which do not open any context menu.
Change-Id: Id9b48440306eeddbd97114bc1ac0f4c9c3c012fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845994
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703792}