Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zziplib: apply patches for CVE-2018-16548 [19.03] #70559

Merged
merged 1 commit into from
Oct 13, 2019
Merged

zziplib: apply patches for CVE-2018-16548 [19.03] #70559

merged 1 commit into from
Oct 13, 2019
+16 −0

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 7, 2019

Motivation for this change

#70135 (security bug)
Master PR: #70558

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@delroth
zziplib: apply patches for CVE-2018-16548

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
59314dd 
(cherry picked from commit aa74d07)
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 7, 2019
@delroth delroth mentioned this pull request Oct 12, 2019
Merged
10 tasks
vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #70559: zziplib: apply patches for CVE-2018-16548
bfce139 
...into release-19.03
@vcunat vcunat merged commit 59314dd into NixOS:staging-19.03 Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @veprbl