jikes: removing #70666
Merged
jikes: removing #70666
+1
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cke You need to remove the callPackage in |
|
And by an alias I mean something like https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L309. And we'll remove it in the next nixos release. |
|
Thanks @worldofpeace ! I've updated the PR. |
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
worldofpeace
approved these changes
Oct 7, 2019
jonringer
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
nix-review looks right
$ nix-env -f /home/jon/.cache/nix-review/pr-70666/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing changed
https://github.com/NixOS/nixpkgs/pull/70666
No packages were successfully build, skip nix-shell
$ git worktree prune
EDIT: please squash commits into one :)
|
I squashed the commits into one |
|
commits should be written in the "imperative mood" https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133 but it's close enough so I'll merge :) |
jonringer
added
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Jikes was an alternative Java compiler. The last release was in 2005 and it hasn't been touched in years. The last Java version it (partially) supports is Java 5. There are no packages depending on it.
Homepage: https://sourceforge.net/projects/jikes/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)