Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jikes: removing #70666

Merged
merged 1 commit into from Oct 8, 2019
Merged

jikes: removing #70666

merged 1 commit into from Oct 8, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 7, 2019

Motivation for this change

Jikes was an alternative Java compiler. The last release was in 2005 and it hasn't been touched in years. The last Java version it (partially) supports is Java 5. There are no packages depending on it.
Homepage: https://sourceforge.net/projects/jikes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@cke You need to remove the callPackage in all-packages.nix and add an alias to aliases.nix.

@worldofpeace
Copy link
Contributor

And by an alias I mean something like https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L309. And we'll remove it in the next nixos release.

@cko
Copy link
Member Author

cko commented Oct 7, 2019

Thanks @worldofpeace ! I've updated the PR.

worldofpeace
worldofpeace approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will backport to the beta release. Can you squash your commits into one?

jonringer
jonringer approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review looks right

$ nix-env -f /home/jon/.cache/nix-review/pr-70666/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing changed
https://github.com/NixOS/nixpkgs/pull/70666
No packages were successfully build, skip nix-shell
$ git worktree prune

EDIT: please squash commits into one :)

@cko
Copy link
Member Author

cko commented Oct 8, 2019

I squashed the commits into one

@jonringer
Copy link
Contributor

commits should be written in the "imperative mood" https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133 but it's close enough so I'll merge :)

jikes: Remove

@jonringer jonringer merged commit 54e4b13 into NixOS:master Oct 8, 2019
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 8, 2019
@worldofpeace
Copy link
Contributor

backported in 30ceb51.
also did eb8f818 because in certain instances, when the message doesn't include the packagename, people have no idea why they're seeing this message.

@cko cko deleted the remove_jikes branch October 12, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cko @worldofpeace @jonringer