Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.arc-menu: 33.2 -> 33 #70533

Merged
merged 1 commit into from Oct 10, 2019
Merged

gnomeExtensions.arc-menu: 33.2 -> 33 #70533

merged 1 commit into from Oct 10, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Despite the 33.3 -> 33 this doesn't appear to be a downgrade.
An actual stable release, where before it was a development version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
gnomeExtensions.arc-menu: 33.2 -> 33
209e90b 
Despite the 33.3 -> 33 this doesn't appear to be a downgrade.
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 6, 2019
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Oct 6, 2019 •
edited

Hmm still isn't clear to me what the correct version is to be using here.
https://extensions.gnome.org/extension/1228/arc-menu/ has a 34 which is development, but 33 supports 3.34.
https://gitlab.com/LinxGem33/Arc-Menu/issues/136 ?

@worldofpeace worldofpeace merged commit dbe6e52 into NixOS:master Oct 10, 2019
@worldofpeace worldofpeace deleted the arc-menu-33 branch October 10, 2019 19:19
@worldofpeace worldofpeace mentioned this pull request Oct 10, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace