Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fileshare: init at 0.2.4 #70416

Merged
merged 1 commit into from Oct 6, 2019
Merged

fileshare: init at 0.2.4 #70416

merged 1 commit into from Oct 6, 2019

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Oct 4, 2019 •
edited

Motivation for this change

Fileshare is a simple tool for sharing the contents of a directory via a
webserver and optionally allowing uploads.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    (No dependencies)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    (+ 44.51 MB)
  • Ensured that relevant documentation is up to date
    (No documentation)
  • Fits CONTRIBUTING.md.
Notify maintainers

CC: myself :)

@tilpner
Copy link
Member

tilpner commented Oct 4, 2019

@GrahamcOfBorg build fileshare

@esclear esclear requested a review from teto October 5, 2019 18:00
@esclear
fileshare: init at 0.2.4
40fae0b 
Fileshare is a simple tool for sharing the contents of a directory via a
webserver and optionally allowing uploads.
@mmahut
Copy link
Member

mmahut commented Oct 5, 2019

@GrahamcOfBorg build fileshare

@teto
Copy link
Member

teto commented Oct 6, 2019

it would be nice if upstream's Makefile would allow VCSVERSION / CC overrides. Meanwhile this works. (of the same type, there is webfs already packaged in nixpkgs).

@teto teto merged commit a4ae914 into NixOS:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@esclear @tilpner @mmahut @teto