Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapods: 1.8.1 -> 1.8.4 #70417

Merged
merged 2 commits into from Nov 7, 2019
Merged

cocoapods: 1.8.1 -> 1.8.4 #70417

merged 2 commits into from Nov 7, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Oct 4, 2019

Motivation for this change

https://github.com/CocoaPods/CocoaPods/releases/tag/1.8.3
https://github.com/CocoaPods/CocoaPods/releases/tag/1.8.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lilyball lilyball changed the title Cocoapods cocoapods: 1.8.1 -> 1.8.3 Oct 19, 2019
@lilyball lilyball changed the title cocoapods: 1.8.1 -> 1.8.3 cocoapods: 1.8.1 -> 1.8.4 Oct 19, 2019
@Mic92
Copy link
Member

Mic92 commented Oct 19, 2019

@GrahamcOfBorg build cocoapods cocoapods-beta

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/75

@marsam marsam merged commit f2ecbaa into NixOS:master Nov 7, 2019
@marsam
Copy link
Contributor

marsam commented Nov 7, 2019

Thanks!

@lilyball lilyball deleted the cocoapods branch November 7, 2019 18:10
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
cocoapods: 1.8.1 -> 1.8.4
(cherry picked from commit f2ecbaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants