Squeezelite updates and refactor #70637
Merged
+49
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version change: upstream is using an
svn2git
setup, and whilst there has never been an official release, version numbers are indicated insqueezelite.h
(see ralph-irving/squeezelite#29).Broken
mp3
,ogg
andaac
support: current build doesn't find libraries at runtime (fixed by added-DLINKALL
):Outout from current build:
Added extra codecs, and features:
Added support for DSD, ALAC, WMA and Opus. Added resampling support and SSL.
Output from new build:
The downside is that the closure size increases from 30,132,336 to 149,554,504. I could disable
ffmpeg
support by default (and with it ALAC & WMA) to reduce the size to 44,408,752 which is a much smaller increase.Added myself as a maintainer.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc (I know you're not listed as a package maintainer, but pinging @peterhoeg)