Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq_8_10: 8.10+β3 → 8.10.0 #70642

Merged
merged 4 commits into from Oct 16, 2019
Merged

coq_8_10: 8.10+β3 → 8.10.0 #70642

merged 4 commits into from Oct 16, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 7, 2019

Motivation for this change

Major release.

This PR is currently a draft, waiting for #70323 to land in master.

Fixes #66217

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zimmi48

This comment has been minimized.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 8, 2019

It has been merged in staging only.

@Zimmi48
Copy link
Member

Zimmi48 commented Oct 8, 2019

Ah right, I misunderstood what was meant by "land in".

@vbgl
Copy link
Contributor Author

vbgl commented Oct 15, 2019

I don’t know how long it takes for staging to be merged into master, so I propose to (temporarily) disable CoqIDE for Coq 8.10.

@GrahamcOfBorg build coqPackages_8_10.interval

@Zimmi48
Copy link
Member

Zimmi48 commented Oct 15, 2019

OK to me. Longer term we may want to split the Coq and CoqIDE packages, but this will probably be easier to do after Coq has switched to Dune as the primary build system.

@Zimmi48
Copy link
Member

Zimmi48 commented Oct 15, 2019

BTW, I just noticed that Coq 8.10+beta2 is in nixos-19.09. Given that this is a pre-release version, shouldn't the update to 8.10+beta3, and the upcoming one to 8.10.0 (maybe after CoqIDE is made available again) be backported?

@vbgl
Copy link
Contributor Author

vbgl commented Oct 15, 2019

The release-19.09 branch has GTK3 at 3.24.10, so you can have CoqIDE there I guess.

Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I cannot merge the PR for you.

@vbgl vbgl merged commit b4db381 into NixOS:master Oct 16, 2019
@vbgl vbgl deleted the coq-8.10.0 branch October 16, 2019 02:43
@vbgl vbgl mentioned this pull request Oct 16, 2019
10 tasks
@SkySkimmer SkySkimmer mentioned this pull request Sep 23, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coq_8_10 broken on darwin
2 participants