Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reliable epson #70491

Merged
merged 6 commits into from
Oct 13, 2019
Merged

Reliable epson #70491

merged 6 commits into from
Oct 13, 2019
+78 −23

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Oct 5, 2019 •
edited
Loading

Motivation for this change

Resolves #70155

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @symphorien @artuuge @furrycatherder @nphilou @emanueleperuffo @romildo @jorsn

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 6, 2019
@jorsn
Copy link
Member

jorsn commented Oct 6, 2019

Why not use https for all webarchive urls?

In epson-escpr2 you specifiy no protocol at all (url = [ … "web.archive.org/…" ]), in epson-escpr you use https while in epson-workforce-635-nx625-series it is only http.

furrycatherder
furrycatherder approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@furrycatherder furrycatherder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wucke13 wucke13 force-pushed the reliable-epson branch 2 times, most recently from 8c32c81 to ac3989d Compare October 6, 2019 14:52
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 6, 2019

@jorsn Thanks for the update. I rushed trough doing it and did not look into it well enough. Adjusted accordingly, obviously your suggestion is good!
@furrycatherder Thanks for the feedback!
If you would go and recheck that all the webarchive links indeed yield the needed hashes, that would be good. I did, but maybe I made mistakes there too...

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 6, 2019
@wucke13 wucke13 requested a review from symphorien October 7, 2019 10:33
symphorien
symphorien approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that the fallback url works for at least one of them. Looks good to me.

@d-goldin
Copy link
Contributor

Thanks for doing this!

@wucke13
Copy link
Contributor Author

wucke13 commented Oct 13, 2019

@Lassulus would you mind checking this?

@Lassulus
Copy link
Member

hmm, I don't have a printer to test this, but most of the commits just changed the upstream url. I would be happy with a more verbose commit message then "etc". maybe something like, use additional mirror url in src ?

@wucke13
epkowa: added mirror url for src
959930f 
+ added webarchive source for reliable builds in the future
@wucke13
epson-201106w: added mirror url for src
e7f3fb9 
+ added webarchive source for reliable builds in the future
@wucke13
epson_201207w: added mirror url for src
25d6f87 
+ added webarchive source for reliable builds in the future
@wucke13
epson-escpr: 1.6.16 -> 1.7.3
bbb71bf 
+ added webarchive source for reliable builds in the future
@wucke13
epson-escpr2: added mirror url for src
4db7494 
+ added webarchive source for reliable builds in the future
+ removed `${version}` from url, as it actually adds more hassle to
  have it in there and no benefits whatsoever, since the url keeps
  changing other parts too
@wucke13
epson-workforce-635-nx625-series: added mirror url for src
3a58913 
+ added webarchive source for reliable builds in the future
@wucke13
Copy link
Contributor Author

wucke13 commented Oct 13, 2019

Ok, adjusted accordingly.

@Lassulus Lassulus merged commit 93016e6 into NixOS:master Oct 13, 2019
@wucke13 wucke13 mentioned this pull request Oct 13, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien

@furrycatherder furrycatherder

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reliable and trustworthy mirror for Epson artifacts (and maybe others)
7 participants
@wucke13 @jorsn @d-goldin @Lassulus @symphorien @furrycatherder @veprbl