Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/doc: fix manpage format #70475

Merged
merged 1 commit into from Oct 5, 2019
Merged

nixos/doc: fix manpage format #70475

merged 1 commit into from Oct 5, 2019

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Oct 5, 2019

Motivation for this change

Spaces inside <refname> cause stray double underscore in generated manual pages.

Fixes #70468

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xzfc
nixos/doc: fix manpage format
0eaf294 
Spaces inside <refname> cause stray double underscore in generated manual pages.

Fixes NixOS#70468
@xzfc xzfc requested a review from nbp as a code owner October 5, 2019 16:12
@xzfc xzfc mentioned this pull request Oct 5, 2019
Closed
@matthewbauer matthewbauer merged commit 5a46cac into NixOS:master Oct 5, 2019
@matthewbauer
Copy link
Member

Thanks for tracking this down! Cherry picked in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos manpages contain stray (?) double underscore for some reason
2 participants
@xzfc @matthewbauer