Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tengine: 2.3.1 -> 2.3.2 #70574

Merged
merged 2 commits into from Oct 15, 2019
Merged

tengine: 2.3.1 -> 2.3.2 #70574

merged 2 commits into from Oct 15, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 7, 2019

Motivation for this change

Changelog: https://github.com/alibaba/tengine/releases/tag/2.3.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from Izorkin October 7, 2019 05:38
@marsam marsam added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 7, 2019
@Izorkin
Copy link
Contributor

Izorkin commented Oct 15, 2019

@marsam thanks, worked.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019 •
edited

@marsam would you mind rebasing on current master and removing meta.broken if this is fixing the build?

@marsam
Copy link
Contributor Author

marsam commented Oct 15, 2019

@c0bw3b done :)

@ofborg ofborg bot requested a review from Izorkin October 15, 2019 19:27
@c0bw3b c0bw3b merged commit 86df0e3 into NixOS:master Oct 15, 2019
c0bw3b pushed a commit that referenced this pull request Oct 15, 2019
@marsam @c0bw3b
tengine: 2.3.1 -> 2.3.2 (#70574)
882e1c7 
* tengine: 2.3.1 -> 2.3.2

Changelog: https://github.com/alibaba/tengine/releases/tag/2.3.2

* tengine: unbreak

(cherry picked from commit 86df0e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izorkin Izorkin Awaiting requested review from Izorkin

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Izorkin @c0bw3b