Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drone-cli: 0.8.6 -> 1.2.0 #70540

Merged
merged 1 commit into from Oct 8, 2019
Merged

drone-cli: 0.8.6 -> 1.2.0 #70540

merged 1 commit into from Oct 8, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Oct 6, 2019

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @elohmeier @bricewge

@ofborg ofborg bot requested a review from kalbasit October 6, 2019 20:14
@c0bw3b c0bw3b mentioned this pull request Oct 6, 2019
Merged
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2019

@GrahamcOfBorg build drone-cli

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 8, 2019 •
edited

Locally it builds and runs on nixos (help message and basic invocation of subcommands resulting in a normal error because I have no config).

One minor thing I notice is the lack of the proper version number in:

$ ./results/drone-cli/bin/drone -v
drone version

@kampka any idea why?

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 8, 2019

@GrahamcOfBorg build drone-cli

@kampka
Copy link
Contributor Author

kampka commented Oct 8, 2019

Looks like the version is compile in via extra build flag: https://github.com/drone/drone-cli/blob/b9b41aadd0c9e816ac0a5eb54fc486717b7349e8/.drone.sh

We can probably add this via the buildFlagsArray.

@kampka
Copy link
Contributor Author

kampka commented Oct 8, 2019

@c0bw3b should be resolved now. Feel free to test again.

./result/bin/drone -v
drone version 1.2.0

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 8, 2019

@GrahamcOfBorg build drone-cli

c0bw3b
c0bw3b approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs and version is shown properly

@c0bw3b c0bw3b merged commit 3fea3bb into NixOS:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @c0bw3b