Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projectm: adopt, Qt{4->5}, {2->3}1.0, patch rpath, clean-up closure #70433

Closed
wants to merge 2 commits into from
Closed

projectm: adopt, Qt{4->5}, {2->3}1.0, patch rpath, clean-up closure #70433

wants to merge 2 commits into from

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Oct 5, 2019 •
edited

Motivation for this change

The package was abandoned in nixpkgs for some time, but upstream is very active.

Now it is in a good state.

Also patching upstream, waiting on issue resolved or not - patch would roll on versions:
Upstream inserts the src path reference during build into ELF rpath, so we must delete it out.
upstream report: projectM-visualizer/projectm#245

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha
projectm: adopt, Qt{4->5}, {2->3}1.0, patch rpath, clean-up closure
6ddb689 
The package was abandoned in nixpkgs for some time, but upstream is very active.

Now it is in a good state.

Also patching upstream, waiting on issue resolved:
NOTE: 2019-10-05: Upstream inserts the src path buring build into ELF rpath,
so must delete it out.
upstream report: projectM-visualizer/projectm#245
This was referenced Oct 5, 2019
Closed
Closed
@mmilata
Copy link
Member

mmilata commented Oct 7, 2019

Thanks for updating this fine piece of software! Unfortunately it doesn't seem to work for me:

$ cd nixpkgs
$ git checkout adopt-projectm
$ nix-build . -A projectm
...
$ ./result-bin/bin/projectM-pulseaudio
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

zsh: abort      ./result-bin/bin/projectM-pulseaudio

Issue #68615 seems similar.

@Anton-Latukha
Copy link
Contributor Author

@mmilata This needed wrapQtAppsHook, I still not accustomed to bother with Nix runtime dependencies. On your system, it now must work.

@mmilata
Copy link
Member

mmilata commented Oct 24, 2019

@Anton-Latukha also had to add f7245ab then it works

@ajs124 ajs124 mentioned this pull request Mar 12, 2020
Closed
10 tasks
@Anton-Latukha
Copy link
Contributor Author

@ajs124

I see that you want to take over this.

I hope you took from this thread everything useful here is.

I do not think I would use projectm much, but I see you probably would, so I close this in favor of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anton-Latukha @mmilata