Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw socket truncated packets #311

Merged
merged 2 commits into from Oct 8, 2019
Merged

raw socket truncated packets #311

merged 2 commits into from Oct 8, 2019

Conversation

MabezDev
Copy link
Contributor

@MabezDev MabezDev commented Oct 7, 2019

Gracefully handle packet truncation errors, instead of panicking. Ran into this when testing smaller MTU sizes.

@whitequark
Copy link
Contributor

  1. Can you add a test?
  2. Can you change the commit message so that the first line isn't just raw_socket:?

@MabezDev
handle truncated packets in raw socket:
c447535 
	Gracefully handle packet truncation errors, instead of panicking
@MabezDev
Add test for raw socket truncated packets
337a4ca
@MabezDev MabezDev force-pushed the raw-socket-handle-truncated-packets branch from c82fa6d to 337a4ca Compare October 7, 2019 10:18
@MabezDev
Copy link
Contributor Author

MabezDev commented Oct 7, 2019

Done. Let me know if there is anything else.

@whitequark whitequark merged commit 0fedb1d into smoltcp-rs:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MabezDev @whitequark