Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettyping: works on unix platforms #70568

Merged
merged 1 commit into from Oct 7, 2019
Merged

prettyping: works on unix platforms #70568

merged 1 commit into from Oct 7, 2019

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Oct 7, 2019

Motivation for this change

prettyping is not linux-specific.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @qoelet

@teto
Copy link
Member

teto commented Oct 7, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from qoelet October 7, 2019 05:34
@jonringer
Copy link
Contributor

@GrahamcOfBorg build prettyping

@jonringer
Copy link
Contributor

builds on darwin

@jonringer jonringer merged commit 4b4b80a into NixOS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qoelet qoelet Awaiting requested review from qoelet

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sigma @teto @jonringer