Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teleport: 4.0.4 -> 4.1.0 #70569

Merged
merged 1 commit into from Oct 15, 2019
Merged

teleport: 4.0.4 -> 4.1.0 #70569

merged 1 commit into from Oct 15, 2019

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Oct 7, 2019

Motivation for this change

bump version to 4.1.0

Also adding myself as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tomberek

jonringer
jonringer approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70569
1 package were build:
teleport

@jonringer
Copy link
Contributor

@GrahamcOfBorg build teleport

@globin globin merged commit ab5b22b into NixOS:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sigma @jonringer @globin