Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.libapreq2: add patch for CVE-2019-12412 #70479

Merged
merged 1 commit into from Nov 1, 2019
Merged

perlPackages.libapreq2: add patch for CVE-2019-12412 #70479

merged 1 commit into from Nov 1, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 5, 2019 •
edited

Motivation for this change

https://security-tracker.debian.org/tracker/CVE-2019-12412

No upstream release yet & we don't appear to have a raw c version of this package, just the perl one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle risicle marked this pull request as ready for review October 5, 2019 17:34
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

@GrahamcOfBorg build perl528Packages.libapreq2 perl530Packages.libapreq2

@aanderse
Copy link
Member

@risicle I believe we do have the the c library packaged right inside the perl package... see ${pkgs.perlPackages.libapreq2}/modules/mod_apreq2.so and the installPhase phase of the perl pacakge.

@risicle
Copy link
Contributor Author

risicle commented Oct 20, 2019

Indeed - I think I was just noting that this is the only place in nixpkgs that it needs patching.

@aanderse
Copy link
Member

Sorry, I misunderstood. Thanks for your efforts!

@aanderse
Copy link
Member

Anyone have any ideas for the perl errors?

@risicle risicle force-pushed the ris-libapreq2-CVE-2019-12412 branch from c259f02 to 68d4a1b Compare October 26, 2019 17:34
@risicle
Copy link
Contributor Author

risicle commented Oct 26, 2019

Seems to have gone after a rebase.

@risicle
Copy link
Contributor Author

risicle commented Oct 27, 2019

@GrahamcOfBorg build perl528Packages.libapreq2 perl530Packages.libapreq2

@aanderse aanderse merged commit 917c498 into NixOS:master Nov 1, 2019
@risicle risicle mentioned this pull request Nov 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @c0bw3b @aanderse @veprbl