nodesPackages.insect: init at 5.4.0 #70652

teto · 2019-10-07T16:47:42Z

a calculator that understands units (online demo at https://insect.sh/).

That's the first node package I am trying to package but I am kinda lost:
install fails with :

> insect@5.3.0 postinstall /nix/store/2nx32z7yz18238z1aaq4zbrbnfywsvd7-node_insect-5.3.0/lib/node_modules/insect
> bower --allow-root install && npm run browserify && npm run copy

sh: bower: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! insect@5.3.0 postinstall: `bower --allow-root install && npm run browserify && npm run copy`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the insect@5.3.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2019-10-07T16_32_49_371Z-debug.log

After grepping a bit, I found that insect's package.json contains

"scripts": {
    "copy": "node copy",
    "browserify:watch": "pulp -w browserify --skip-entry-point -m Insect --standalone Insect -O -t insect.js",
    "browserify": "pulp browserify --skip-entry-point -m Insect --standalone Insect -O -t insect.js",
    "build": "pulp build -m Insect",
    "server": "live-server web --open",
    "test": "pulp test"
  },

I tried to remove these scripts entries but then it would fail at runtime with

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module './output/Insect/index.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/nix/store/8m3kfh6zi8pqvi6pblsgn6fm4jkhn5g0-node_insect-5.3.0/lib/node_modules/insect/index.js:3:14)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)

should I package this with bower2nix instead ? or the package is broken for nix ? I precise I have no interest watsoever in the webapp, I just want to use the terminal component.

CC @svanderburg

Motivation for this change

Things done

Notify maintainers

cc @

teto · 2019-10-08T08:39:54Z

I managed to make it work imperatively so that's helpful for now.

Even though I added purescript as a buildInput (with #67875 so that it matches the requested version) it doesn't seem to detect purs (if I run nix-shell -A nodePackages_10_x.insect ~/nixpkgs, $ purs --version returns 0.13.3 and still tries to phone home

✖ Check if a prebuilt 0.13.3 binary is provided for linux
  Error: getaddrinfo ENOTFOUND github.com github.com:443
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:56:26)
▬ Download the prebuilt PureScript binary
▬ Verify the prebuilt binary works correctly
▬ Save the downloaded binary to the npm cache directory

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! purescript@0.13.3 postinstall: `install-purescript --purs-ver=0.13.3`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the purescript@0.13.3 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2019-10-08T08_33_54_813Z-debug.log

Now if I run nix-build with --option sandbox false, I get another error

✔ Download the prebuilt PureScript binary
⠋ Verify the prebuilt binary works correctly
  Save the downloaded binary to the npm cache directory

✖ Verify the prebuilt binary works correctly
  /nix/store/z1qa5bpmx2pm7dbqm1frma4ah857dlrj-node_insect-5.3.0/lib/node_mod…
  Error: spawn /nix/store/z1qa5bpmx2pm7dbqm1frma4ah857dlrj-node_insect-5.3.0/lib
/node_modules/insect/node_modules/purescript/purs.bin ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
▬ Save the downloaded binary to the npm cache directory

↓ Fallback: building from source

✖ Check if 'stack' command is available
  stack --allow-different-user --numeric-version
  Error: Command failed with exit code 2 (ENOENT): stack --allow-different-user 
--numeric-version
spawn stack ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:19)
    at onErrorNT (internal/child_process.js:415:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
▬ Download the PureScript 0.13.3 source
▬ Ensure the appropriate GHC is installed
▬ Build a binary from source
▬ Save the built binary to the npm cache directory

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! purescript@0.13.3 postinstall: `install-purescript --purs-ver=0.13.3`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the purescript@0.13.3 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/nix-build-node_insect-5.3.0.drv-24/.npm/_logs/2019-10-08T08_38_55_268Z-debug.log

teto · 2019-10-08T08:51:40Z

@justinwoo I wonder if you would know why npm install doesn't pick up the purescript interpreter purs in the build environment and still try to fetch it ? any workaround ?

lilyball · 2020-01-12T23:58:20Z

I'd love to see insect be packaged but I don't understand anything about bower or how to make this work.

lilyball · 2020-01-13T00:00:01Z

I noticed there's a bower2nix command but it seems like it's supposed to be used as part of a larger derivation so I don't know how to package up the output.

nixos-discourse · 2020-01-22T21:04:25Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-packaging-a-node-package-insect-that-uses-bower/5602/1

lilyball

With insect v5.4.0 we can now get this to work

lilyball · 2020-01-26T03:14:35Z

pkgs/development/node-packages/default-v10.nix

+  insect = nodePackages.insect.override {
+    buildInputs = [ nodePackages.pulp nodePackages.bower pkgs.purescript ];
+  };


Suggested change

insect = nodePackages.insect.override {

buildInputs = [ nodePackages.pulp nodePackages.bower pkgs.purescript ];

};

insect = nodePackages.insect.override (drv: {

nativeBuildInputs = drv.nativeBuildInputs or [] ++ [ pkgs.psc-package pkgs.purescript nodePackages.pulp ];

});

lilyball · 2020-01-26T03:16:36Z

pkgs/development/node-packages/node-packages-v10.json

@@ -55,6 +55,7 @@
 , "hueadm"
 , "imapnotify"
 , "indium"
+, "insect"


Update this to v5.4.0, which gets rid of the bower dependency

lilyball · 2020-01-27T21:15:45Z

pkgs/development/node-packages/composition-v13.nix

@@ -2,7 +2,7 @@

 {pkgs ? import <nixpkgs> {
    inherit system;
-  }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}:
+  }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}:


This needs to be fixed again.

lilyball · 2020-01-27T21:16:29Z

pkgs/development/node-packages/node-packages-v12.nix

@@ -13,13 +13,13 @@ let
        sha512 = "nne9/IiQ/hzIhY6pdDnbBtz7DjPTKrY00P/zvPSm5pOFkl6xuGrGnXn/VtTNNfNtAfZ9/1RtehkszU9qcTii0Q==";
      };
    };
-    "ajv-6.10.2" = {


We probably don't need to commit changes to the v12 or v13 package sets when you're just trying to update the v10 one.

teto · 2020-01-29T12:44:16Z

thanks for the help. The binary seems to work.

a calculator that understands units (online demo at https://insect.sh/)

lilyball · 2020-01-29T23:38:24Z

pkgs/development/node-packages/default-v10.nix

@@ -35,6 +35,10 @@ nodePackages // {
    name = "bitwarden-cli-${drv.version}";
  });

+  insect = nodePackages.insect.override {
+    nativeBuildInputs = [ pkgs.psc-package pkgs.purescript nodePackages.pulp ];


I'm not sure if node2nix sets up any default nativeBuildInputs but just in case this really should be

insect = nodePackages.insect.override (drv: { nativeBuildInputs = drv.nativeBuildInputs or [] ++ [ pkgs.psc-package pkgs.purescript nodePackages.pulp ]; });

seems like it doesnt https://github.com/teto/nixpkgs/blob/dece5e6d0bd5556018ee1faf19bf94f3e1672849/pkgs/development/node-packages/node-env.nix#L376

Ok, but we don't want to step on its toes if buildNodePackage is ever updated in the future to start using nativeBuildInputs.

lilyball · 2020-02-25T23:58:09Z

Since this PR seems to have stalled out I submitted a new one as #81070

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 7, 2019

teto force-pushed the insect branch from d44f732 to cd59cce Compare October 8, 2019 08:09

teto mentioned this pull request Jan 13, 2020

request: nota #77590

Closed

lilyball reviewed Jan 26, 2020

View reviewed changes

teto force-pushed the insect branch from cd59cce to 18389e5 Compare January 26, 2020 18:54

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 27, 2020

lilyball reviewed Jan 27, 2020

View reviewed changes

teto force-pushed the insect branch from 21092d3 to dece5e6 Compare January 29, 2020 12:05

ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 11-100 labels Jan 29, 2020

teto changed the title ~~nodesPackages.insect: init at 5.3.0~~ nodesPackages.insect: init at 5.4.0 Jan 29, 2020

teto marked this pull request as ready for review January 29, 2020 12:42

teto added 2 commits January 29, 2020 14:03

nodesPackages.insect: init at 5.4.0

c9d385e

a calculator that understands units (online demo at https://insect.sh/)

nodejs-10_x: add insect

dece5e6

lilyball reviewed Jan 29, 2020

View reviewed changes

lilyball mentioned this pull request Feb 25, 2020

nodePackages.insect: init at 5.4.0 #81070

Merged

10 tasks

teto closed this Feb 26, 2020

teto deleted the insect branch February 26, 2020 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nodesPackages.insect: init at 5.4.0 #70652

nodesPackages.insect: init at 5.4.0 #70652

teto commented Oct 7, 2019 •

edited

teto commented Oct 8, 2019

teto commented Oct 8, 2019

lilyball commented Jan 12, 2020

lilyball commented Jan 13, 2020

nixos-discourse commented Jan 22, 2020

lilyball left a comment

lilyball Jan 26, 2020

lilyball Jan 26, 2020

lilyball Jan 27, 2020

lilyball Jan 27, 2020

teto commented Jan 29, 2020

lilyball Jan 29, 2020

teto Jan 30, 2020

lilyball Jan 31, 2020

lilyball commented Feb 25, 2020

nodesPackages.insect: init at 5.4.0 #70652

nodesPackages.insect: init at 5.4.0 #70652

Conversation

teto commented Oct 7, 2019 • edited

Motivation for this change

Things done

Notify maintainers

teto commented Oct 8, 2019

teto commented Oct 8, 2019

lilyball commented Jan 12, 2020

lilyball commented Jan 13, 2020

nixos-discourse commented Jan 22, 2020

lilyball left a comment

Choose a reason for hiding this comment

lilyball Jan 26, 2020

Choose a reason for hiding this comment

lilyball Jan 26, 2020

Choose a reason for hiding this comment

lilyball Jan 27, 2020

Choose a reason for hiding this comment

lilyball Jan 27, 2020

Choose a reason for hiding this comment

teto commented Jan 29, 2020

lilyball Jan 29, 2020

Choose a reason for hiding this comment

teto Jan 30, 2020

Choose a reason for hiding this comment

lilyball Jan 31, 2020

Choose a reason for hiding this comment

lilyball commented Feb 25, 2020

teto commented Oct 7, 2019 •

edited