Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mumble,murmur: 1.2.19 -> 1.3.0 #68800

Merged
merged 1 commit into from Oct 7, 2019
Merged

mumble,murmur: 1.2.19 -> 1.3.0 #68800

merged 1 commit into from Oct 7, 2019

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Sep 14, 2019 •
edited

Motivation for this change

Mumble v1.3.0 was officially released few weeks ago. This PR aims to update the package for both client (mumble) and server (murmur).
This also updates to the qt5's makeDerivation (see #67270).
I removed the now useless murmur_rc and mumble_rc packages, but I don't know how you feel about it?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@infinisil
Copy link
Member

Nice, tested it and it's working well. Can you squash the commits into one?

@greizgh
Copy link
Contributor Author

greizgh commented Oct 7, 2019

Sure! Here you go, squashed and rebased.

@infinisil infinisil merged commit ff41ef1 into NixOS:master Oct 7, 2019
@ajs124
Copy link
Member

ajs124 commented Oct 7, 2019

This (seems to) break(s) mumble.override. As in, building mumble.override { pulseSupport = true; } doesn't work anymore.

@infinisil infinisil mentioned this pull request Oct 7, 2019
Merged
2 tasks
@infinisil
Copy link
Member

@ajs124 Thanks for the report, this was easy to miss, I've opened #70685 to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greizgh @infinisil @ajs124