Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6407: Show snowy ground sprites for depots #7671

Merged
merged 1 commit into from Oct 8, 2019

Conversation

stormcone
Copy link
Contributor

This is a quick fix by @KeldorKatarn:
KeldorKatarn/OpenTTD_PatchPack@65e656b

It has the drawback that snow is draw to the inside the depots as well, as the removed comment suggests.

snow_in_depot

This is a quick fix by @KeldorKatarn:
KeldorKatarn/OpenTTD_PatchPack@65e656b

It has the drawback that snow is draw to the inside the depots as well, as the removed comment suggests.
@LordAro
Copy link
Member

LordAro commented Jul 27, 2019

I fear I have to agree with the original comment - it does look weird

Original comment dates back to r1 - https://github.com/OpenTTD/OpenTTD/blame/ebc18e3957ceaf2c3fdd208a3ad6590875caf8de/rail_cmd.c#L1529

@Eddi-z
Copy link
Contributor

Eddi-z commented Jul 27, 2019

Could be made a railtype flag, so only NewGRF railtypes who care (and are programmed to handle it) show the climate-specific sprite?

@jcoletto77
Copy link

That inconvenient can be overcome by the NewGRF author, if he supplies an overlay for the in-depot ground. In other words, the "snowy" depot sprite should be drawn so that it includes dark ground that will cover the snow.

@planetmaker
Copy link
Contributor

planetmaker commented Oct 7, 2019

Could be made a railtype flag, so only NewGRF railtypes who care (and are programmed to handle it) show the climate-specific sprite?

It's a bit the question what is the lesser evil: snow inside the depot or no snow around the depot. Both looks weired. IMHO the snow inside (maybe attributed to wind) is less visible than no snow around the depot (attributed to heat from the shed) - but YMMV.

As to NewGRFs... yes, a flag could work and save lengthy groundtype decision trees. But with this patch it wouldn't be needed either as it could be simplified to "check snow" instead of all land types possible.

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, definitely looks less weird than the alternative

@planetmaker planetmaker merged commit f1712a5 into OpenTTD:master Oct 8, 2019
@stormcone stormcone deleted the fix-6407 branch October 8, 2019 19:58
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
This is a quick fix by @KeldorKatarn:
KeldorKatarn/OpenTTD_PatchPack@65e656b

It has the drawback that snow is draw to the inside the depots as well, as the removed comment suggests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants