Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MojoSQLite: init at 3.002 #70654

Merged
merged 1 commit into from Oct 14, 2019
Merged

perlPackages.MojoSQLite: init at 3.002 #70654

merged 1 commit into from Oct 14, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 7, 2019

Motivation for this change

This PR adds Mojo::SQLite at version 3.002.

Latest is 3.003, but not used as it requires perlPackages.DBDSQLite >= 1.64 and
sqlite >= 3.29.0. Upgrading sqlite seems out of scope for this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@stigtsp
perlPackages.MojoSQLite: init at 3.002
1e4eed8 
Latest is 3.003, but not used as it requires perlPackages.DBDSQLite >= 1.64 and
sqlite >= 3.29.0
c0bw3b
c0bw3b approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 70654 1

2 package were build:
  • perl528Packages.MojoSQLite
  • perl530Packages.MojoSQLite

@c0bw3b c0bw3b merged commit 5334d3a into NixOS:master Oct 14, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

BTW @stigtsp you will be able to bump both DBDSQLite & MojoSQLite after #70593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @c0bw3b