Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bat: update dependencies #70585

Merged
merged 1 commit into from Oct 10, 2019
Merged

bat: update dependencies #70585

merged 1 commit into from Oct 10, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Oct 7, 2019

Remove zlib, this is no longer a dependency as of at least 0.12.0.

While we're at it, switch to using installShellFiles to install the manpage/completion.

Motivation for this change

sharkdp/bat#678 removed the instructions saying bat required cmake and zlib. We already dropped the cmake requirement earlier but were still declaring the zlib dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Remove zlib, this is no longer a dependency as of at least 0.12.0.

While we're at it, switch to using installShellFiles to install the
manpage/completion.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[2 built, 5 copied (751.6 MiB), 226.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70585
1 package were build:
bat

@nlewo
Copy link
Member

nlewo commented Oct 10, 2019

Cool! Thx.

@nlewo nlewo merged commit 072edcb into NixOS:master Oct 10, 2019
@dywedir
Copy link
Member

dywedir commented Oct 10, 2019

Thanks! It seems like we can remove pkg-config too.

@lilyball
Copy link
Member Author

That's probably true.

@lilyball lilyball deleted the bat-updates branch October 10, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants