Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polkit: propagate glib, other cleanups #70453

Merged
merged 3 commits into from Oct 9, 2019
Merged

polkit: propagate glib, other cleanups #70453

merged 3 commits into from Oct 9, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
polkit: propagate glib
a61db21 
polkit-gobject-1.pc has glib in Requires, and polkit-agent-1.pc
requires polkit-gobject-1.
@worldofpeace
polkit: drop -Wno-deprecated-declarations
670c000 
appears to be uneeded.
@worldofpeace
polkit: drop obsolete comments, whitespace
e570377
jtojnar
jtojnar approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it appears that polkit-agent headers include gobject headers too, even though they are not mentioned in its Requires.

@worldofpeace worldofpeace merged commit e614985 into NixOS:staging Oct 9, 2019
@worldofpeace
Copy link
Contributor Author

Thanks @jtojnar

@worldofpeace worldofpeace deleted the polkit-propagate-glib branch October 9, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar