Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.awkward: 0.12.6 -> 0.12.12 #70545

Merged
merged 1 commit into from Oct 7, 2019
Merged

pythonPackages.awkward: 0.12.6 -> 0.12.12 #70545

merged 1 commit into from Oct 7, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

edit:
Closes #69791

@veprbl veprbl requested a review from FRidh as a code owner October 6, 2019 22:53
@ofborg ofborg bot requested a review from costrouc October 6, 2019 23:05
@veprbl
Copy link
Member Author

veprbl commented Oct 6, 2019

@GrahamcOfBorg build python27Packages.awkward python27Packages.uproot python27Packages.uproot-methods
@GrahamcOfBorg build python37Packages.awkward python37Packages.uproot python37Packages.uproot-methods

@jonringer
Copy link
Contributor

closes #69791

jonringer
jonringer approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[8 built, 3 copied (77.8 MiB), 8.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70545
6 package were build:
python27Packages.awkward python27Packages.uproot python27Packages.uproot-methods python37Packages.awkward python37Packages.uproot python37Packages.uproot-methods

@jonringer jonringer merged commit 54435c9 into NixOS:master Oct 7, 2019
@veprbl veprbl deleted the pr/awkward_0_12_12 branch December 1, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @jonringer