ghc modules: use specific commit to fetch patches #70546
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than master to retrieve patches, some of which have gone stale
ofborg
bot
added
6.topic: haskell
10.rebuild-darwin: 0
veprbl
approved these changes
Oct 6, 2019
veprbl
added
the
8.has: port to stable
|
Please target these kind of changes to the Also, when patches from head.hackage disappear, then the reason is that they have become unnecessary, i.e. because a new version of the package in question has come out. The right response in that situation is to drop the override from Nixpkgs enturely and to use the proper solution, like, update the version of the package that didn't work before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than master to retrieve patches, some of which have gone stale
Motivation for this change
URLs for a few module patches used for building ghc 8.8 have gone stale since they refer to the master branch, which has since moved on and removed 8.8 stuff. This pins them at the last commit where they existed.
Note that there are other patches in this same file pulling from hvr/head.hackage master as well, which need fixing. However, those even refer to an old repo (github.com/hvr/head.hackage, which has moved to gitlab.haskell.org), and are still working for the moment, so I've left them alone. I can take a stab at updating them if that'd be helpful.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti