Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpng12: 1.2.57 -> 1.2.59 [19.03] #70425

Merged
merged 1 commit into from
Oct 5, 2019
Merged

libpng12: 1.2.57 -> 1.2.59 [19.03] #70425

merged 1 commit into from
Oct 5, 2019
+2 −2

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Oct 4, 2019 •
edited
Loading

CVE-2017-12652

Should this go into release-19.03 or staging-19.03?

Motivation for this change

#70106

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 28905760 -> 28906296 (~1KiB diff)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Fuuzetsu

Sorry, something went wrong.

@mmilata mmilata changed the title libpng12: 1.2.57 -> 1.2.59 libpng12: 1.2.57 -> 1.2.59 [19.03] Oct 4, 2019
@mmilata mmilata mentioned this pull request Oct 4, 2019
Merged
10 tasks
@mmilata
libpng12: 1.2.57 -> 1.2.59

Verified

This commit was signed with the committer’s verified signature.
joshka Josh McKinney
GPG key ID: 722287396A903BC5
Verified
Learn about vigilant mode
b045330 
CVE-2017-12652

(cherry picked from commit 12f31b7)
@mmilata mmilata force-pushed the bump-libpng12-19.03 branch from 7df044f to b045330 Compare October 4, 2019 23:51
@ofborg ofborg bot requested a review from Fuuzetsu October 4, 2019 23:51
@vcunat vcunat self-assigned this Oct 5, 2019
vcunat
vcunat approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES seem quite safe, just as ABI tracker.

@vcunat vcunat merged commit b045330 into NixOS:release-19.03 Oct 5, 2019
@vcunat
Copy link
Member

vcunat commented Oct 5, 2019

There aren't many reverse dependencies (1.2 is ancient), which is why it can be merged directly. (And why it the fix doesn't matter too much anyway.)

@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@Fuuzetsu Fuuzetsu

Assignees

@vcunat vcunat

Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @vcunat